Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#397 closed defect (fixed)

Regression in sh_static.c

Reported by: rainer Owned by: rainer
Priority: major Milestone: 4.1.3
Component: main Version: 4.0.0
Keywords: Cc:

Description

The changes for version 4 in sh_static.c led to a regression when samhain is compiled with '--enable-static' (reported by amaiket).

   993  static int __length_dotted(const unsigned char *data, int offset)
   994  {
   995          int orig_offset = offset;
   996          int l;
   997
   998          if (!data)
   999                  return -1;
  1000
  1001          while ((l = data[offset])) {
  1002
  1003                  if (offset < INT_MAX)
  1004                          offset++;
  1005                  else
  1006                          return -1;

Originally it was

                while ((l = data[offset])) { 

so the new code doesn't increment offset if it breaks out of the while loop.

Change History (1)

comment:1 by rainer, 8 years ago

Resolution: fixed
Status: newclosed

Believed to be fixed by changeset [501].

Note: See TracTickets for help on using tickets.