Changeset 22 for trunk/src/sh_mail.c

Timestamp:

Feb 23, 2006, 12:03:58 AM (19 years ago)

Author:

rainer

Message:

Minor code revisions.

File:

• trunk/src/sh_mail.c (modified) (20 diffs)

trunk/src/sh_mail.c

@@ -271 +271 @@
 
 static
-int sh_filter_filteradd (char * argstring, sh_filter_type * filter, int ftype)
+int sh_filter_filteradd (const char * argstring, 
+                         sh_filter_type * filter, int ftype)
 {
   int     i = 0;
@@ -372 +373 @@
  */
 static 
-int sh_filter_filter (char * message, sh_filter_type * filter)
+int sh_filter_filter (const char * message, sh_filter_type * filter)
 {
   int i;
@@ -432 +433 @@
  * -- add keywords to the OR filter
  */
-int sh_mail_add_or (char * str)
+int sh_mail_add_or (const char * str)
 {
   return (sh_filter_filteradd (str, &(mail_filter), SH_FILT_OR));
@@ -440 +441 @@
  * -- add keywords to the AND filter
  */
-int sh_mail_add_and (char * str)
+int sh_mail_add_and (const char * str)
 {
   return (sh_filter_filteradd (str, &(mail_filter), SH_FILT_AND));
@@ -448 +449 @@
  * -- add keywords to the NOT filter
  */
-int sh_mail_add_not (char * str)
+int sh_mail_add_not (const char * str)
 {
   return (sh_filter_filteradd (str, &(mail_filter), SH_FILT_NOT));
@@ -473 +474 @@
 }
 
-int sh_mail_setaddress (char * address)
+int sh_mail_setaddress (const char * address)
 {
   char     *     p;
@@ -523 +524 @@
 }
 
-int sh_mail_setaddress_int (char * address)
+int sh_mail_setaddress_int (const char * address)
 {
   int i;
@@ -533 +534 @@
 }
 
-int sh_mail_setNum (char * str)
+int sh_mail_setNum (const char * str)
 {
   int i = atoi (str);
@@ -549 +550 @@
 static int all_in_one = S_FALSE;
 
-int sh_mail_setFlag (char * str)
+int sh_mail_setFlag (const char * str)
 {
   int i;
@@ -559 +560 @@
 static char * mail_subject = NULL;
 
-int set_mail_subject (char * str)
+int set_mail_subject (const char * str)
 {
   SL_ENTER(_("set_mail_subject"));
@@ -1006 +1007 @@
         /* reveal first signature key
          */
-        (void) sl_strlcpy(skey->crypt, skey->mailkey_new, KEY_LEN+1);
+        /* flawfinder: ignore */
+        (void) sl_strlcpy(skey->crypt, skey->mailkey_new, KEY_LEN+1); 
 
         BREAKEXIT(sh_util_encode);
+        /* flawfinder: ignore */
         sh_util_encode(skey->crypt, bufcompress, 0, 'A');
 
+        /* flawfinder: ignore */
         (void) sl_strlcat (mailMsg, skey->crypt, msgbufsize);
+        /* flawfinder: ignore */
         memset (skey->crypt, 0, KEY_LEN);
         isfirst = 0;
@@ -1021 +1026 @@
     (void) sl_strlcpy (skey->mailkey_old, skey->mailkey_new, KEY_LEN+1);
 
-    /*@-bufferoverflowhigh@*/
-    sprintf(subject, _("%06d %010ld::%s\r\n"),         /* known to fit  */
-            mailcount, (long) id_audit, sh.host.name);
-    /*@+bufferoverflowhigh@*/
+    sl_snprintf(subject, sizeof(subject), _("%06d %010ld::%s\r\n"),
+                mailcount, (long) id_audit, sh.host.name);
 
     (void) sl_strlcat (mailMsg, subject, msgbufsize);
@@ -1222 +1225 @@
 static char * relay_host = NULL;
 
-int sh_mail_set_relay (char * str_s)
+int sh_mail_set_relay (const char * str_s)
 {
   size_t i = 0;
@@ -1251 +1254 @@
 static char * mail_sender = NULL;
 
-int sh_mail_set_sender (char *str)
+int sh_mail_set_sender (const char *str)
 {
   if (mail_sender != NULL) 
@@ -1735 +1738 @@
       if (g != 1)
         {
-          /*@-bufferoverflowhigh@*/
-          sprintf(errmsg,                              /* known to fit  */
-                  _("Bad response (%d), expected %d"), rcode, code);
-          /*@+bufferoverflowhigh@*/
+          sl_snprintf(errmsg, sizeof(errmsg),
+                      _("Bad response (%d), expected %d"), rcode, code);
+
           sh_error_handle((-1), FIL__, __LINE__, 0, MSG_E_NET, 
                           errmsg, _("sh_mail_wait"), 
@@ -1883 +1885 @@
   int  ret, length, status;
   mx * result;
+  size_t len;
 
   typedef union
@@ -2065 +2068 @@
        */
       result[count].pref = pref;
-      result[count].address = SH_ALLOC (strlen (expanded) + 1);
-      strcpy (result[count].address, expanded);        /* known to fit  */
+      len = strlen (expanded) + 1;
+      result[count].address = SH_ALLOC (len);
+      sl_strlcpy (result[count].address, expanded, len);
     }
   while (ret > 0 && comp_dn < eom && count);
@@ -2101 +2105 @@
   mx     * result;
   dnsrep * retval;
-  char     errmsg[128]; 
+  char     errmsg[128];
+  size_t   len;
 
   SL_ENTER(_("return_mx"));
@@ -2128 +2133 @@
                            _("get_mx"));
 #else
+          /* flawfinder: ignore *//* test code only */
           strcpy  (errmsg,                               /* known to fit  */
                    _("No MX record for domain "));
@@ -2155 +2161 @@
       result->pref  = 0;
       /*@-type@*/
-      result->address = SH_ALLOC (strlen (host->h_name) + 1);
-      strcpy (result->address, host->h_name);          /* known to fit  */
+      len = strlen (host->h_name) + 1;
+      result->address = SH_ALLOC (len);
+      sl_strlcpy (result->address, host->h_name, len);
       /*@+type@*/
       SL_RETURN (retval, _("return_mx"));