id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
251	Compile error if option --with-prelude is used	rainer	rainer	"As noticed by Sean Chittenden, there's a compile error with the option --with-prelude:
{{{
gcc  -DHAVE_CONFIG_H -I. -I./include   -O2 -D_FORTIFY_SOURCE=2 -fstack-protector-all -fPIE -Wall -W  -fno-strength-reduce -fno-omit-frame-pointer -Wno-empty-body  -DSH_WITH_SERVER -o sh_forward.o -c x_sh_forward.c
x_sh_forward.c: In function ‘check_protocol’:
x_sh_forward.c:3617: error: incompatible type for argument 3 of ‘sh_ipvx_ntoa’
./include/sh_ipvx.h:66: note: expected ‘struct sh_sockaddr *’ but argument is of type ‘struct sh_sockaddr’
}}}

The patch provided by him:

{{{
@@ -3614,7 +3614,7 @@
#if defined(SH_WITH_SERVER) && defined(HAVE_LIBPRELUDE)
{
char peer_ip[SH_IP_BUF];
- sh_ipvx_ntoa(peer_ip, sizeof(peer_ip), conn->addr_peer);
+ sh_ipvx_ntoa(peer_ip, sizeof(peer_ip), &(conn->addr_peer));
sh_error_set_peer_ip( peer_ip );
}
#endif
}}}
"	defect	closed	major	2.8.5	main		fixed