Changeset 524 for trunk

Timestamp:

Apr 6, 2017, 7:42:05 PM (8 years ago)

Author:

katerina

Message:

Fix for ticket #419 (broken SetSocketPassword authentication).

Location:

trunk

Files:

• docs/Changelog (modified) (1 diff)
• src/sh_socket.c (modified) (3 diffs)

trunk/docs/Changelog

@@ -1 +1 @@
 4.2.1:
+        * fix for broken SetSocketPassword authentication
+        (reported by Todd Stansell)
         * fix compile issue on Solaris 11 (reported by Rolf)
         * fix alignment problem with semget() (reported by Rolf)

trunk/src/sh_socket.c

@@ -809 +809 @@
 
 #if defined(NEED_PASSWORD_AUTH)
-char * check_password(char * message, int * client_uid, int talkfd)
+char * check_password(char * message, size_t msglen, int * client_uid, int talkfd)
 {
   char * cmd = NULL;
@@ -823 +823 @@
    */
   if (0 == strcmp(goodpassword, message) &&
-      strlen(goodpassword) < (sizeof(message)/2))
+      strlen(goodpassword) < (msglen/2))
     {
       *client_uid = sh_socket_flaguid;
@@ -902 +902 @@
 
 #elif defined(NEED_PASSWORD_AUTH)
-  cmd = check_password(message, &client_uid, talkfd);
+  cmd = check_password(message, sizeof(message), &client_uid, talkfd);
 
 #else