Changes in trunk/src/sh_getopt.c [20:27]

File:

• trunk/src/sh_getopt.c (modified) (7 diffs)

trunk/src/sh_getopt.c

@@ -80 +80 @@
     sh_util_set_interactive },
 #endif
+#if defined(SH_WITH_SERVER) || defined(SH_WITH_CLIENT)
+  { N_("server-port"),  
+    '-', 
+    N_("Set the server port to connect to"),  
+    HAS_ARG_YES, 
+    sh_forward_server_port },
+#endif
 #ifdef SH_WITH_SERVER
   { N_("server"),  
@@ -112 +119 @@
     HAS_ARG_YES, 
     sh_calls_set_bind_addr },
-#ifdef SH_WITH_CLIENT
+#if defined(SH_WITH_SERVER) || defined(SH_WITH_CLIENT)
   { N_("set-export-severity"),  
     'e', 
@@ -391 +398 @@
     if (op_table[i].hasArg == HAS_ARG_NO) {
       if (sl_strlen(op_table[i].longopt) < 10) 
-        strcpy(fmt,_("%c%c%c        --%-s,\t\t\t %s\n"));/* known to fit  */
+        sl_strlcpy(fmt,_("%c%c%c        --%-s,\t\t\t %s\n"), sizeof(fmt));
       else if (sl_strlen(op_table[i].longopt) < 17)
-        strcpy(fmt, _("%c%c%c        --%-s,\t\t %s\n")); /* known to fit  */
+        sl_strlcpy(fmt, _("%c%c%c        --%-s,\t\t %s\n"), sizeof(fmt));
       else 
-        strcpy(fmt, _("%c%c%c        --%-s,\t %s\n"));   /* known to fit  */
-      /*@-formatconst@*/
-      fprintf (stdout,
-               fmt,
+        sl_strlcpy(fmt, _("%c%c%c        --%-s,\t %s\n"), sizeof(fmt));
+      /* flawfinder: ignore */
+      fprintf (stdout, fmt,
                (op_table[i].shortopt == '-') ? ' ' : '-',
                (op_table[i].shortopt == '-') ? ' ' : op_table[i].shortopt,
@@ -404 +410 @@
                _(op_table[i].longopt),
                _(op_table[i].usage));
-      /*@+formatconst@*/
     } else {
       if (sl_strlen(op_table[i].longopt) < 12) 
-        strcpy(fmt,                                      /* known to fit  */
-               _("%c%c %s  --%-s=<arg>,\t\t %s\n"));  
+        sl_strlcpy(fmt, _("%c%c %s  --%-s=<arg>,\t\t %s\n"), sizeof(fmt));  
       else 
-        strcpy(fmt,                                      /* known to fit  */ 
-               _("%c%c %s  --%-s=<arg>,\t %s\n"));   
-      /*@-formatconst@*/
-      fprintf (stdout,
-               fmt,
+        sl_strlcpy(fmt, _("%c%c %s  --%-s=<arg>,\t %s\n"), sizeof(fmt));   
+      /* flawfinder: ignore */
+      fprintf (stdout, fmt,
                (op_table[i].shortopt == '-') ? ' ' : '-',
                (op_table[i].shortopt == '-') ? ' ' : op_table[i].shortopt,
@@ -420 +422 @@
                _(op_table[i].longopt),
                _(op_table[i].usage));
-      /*@+formatconst@*/
     }
   }
@@ -560 +561 @@
           for (i = 0; op_table[i].longopt != NULL; ++i) 
             {
-      
+
               if (sl_strncmp(_(op_table[i].longopt), 
                              &argv[1][2], 
@@ -568 +569 @@
                   if ( op_table[i].hasArg == HAS_ARG_YES ) 
                     {
-                      if ( (theequal = strchr(argv[1], '=')) == NULL) 
+                      theequal = strchr(argv[1], '=');
+                      if (theequal == NULL) 
                         { 
                           if (argc < 3)